Abdelrazak Younes wrote: > Georg Baum wrote: >> do you still need that patch? > > No, not since I have done my own hand-made conversion in qt_helpers.
Good. That means that I understand what goes on in the conversion routines :-) >> Furthermore the byte order change does not happen in bytes_to_ucs2. > > We don't use that anymore for the qt4 frontend. I know, and that is probably the reason why it works now. >> I believe that the attached patch should make the unicode conversions >> work on little and big endian machines, and removes the uncertainty >> whether UCS-4 is LE or BE. >> >> Using UCS4-INTERNAL and memmove() the result as suggested by Angus would >> be even better, but it seems that it is not available on windows. > > How do you know? I thought I read that, but I may be wrong. Anyway, later I discovered that it is not present in standaard libc iconv on linux either, so we can't use it. > I'll try... But quite frankly I'd rather get rid of the iconv > dependency. Especially since your patch distinguish between BE and LE. > The code is available elsewhere so why not just do our own utf8 to/from > ucs4 adapted to docstring and be done with it. That seems the only sane > approach. We'll see. Using iconv more efficiently is possible, and has the advantage that we do not need to maintain our own code, but I see also your points. Georg
