Re: generating project files with cmake

[Abdelrazak Younes]

Abdelrazak Younes wrote:

Edwin Leuven wrote:

Peter Kümmel wrote:

It crashes? Here I've no problems.

that was a missing sysdir.

now it crashes when i open the document settings dialog and then close it again

The problems lies in Dialogs.C:

void Dialogs::disconnect(string const & name)
{
    if (!isValidName(name))
        return;

    open_insets_[name] = 0;  // <= HERE
}

open_insets_ is empty, hence the crash.

This patch solves it. Committing now.

I am wondering how/why it went unnoticed up until now...

Abdel.

Index: Dialogs.C
===================================================================
--- Dialogs.C   (revision 14886)
+++ Dialogs.C   (working copy)
@@ -157,7 +157,8 @@
        if (!isValidName(name))
                return;
 
-       open_insets_[name] = 0;
+       if (open_insets_.find(name) != open_insets_.end())
+               open_insets_[name] = 0;
 }