Joost Verburg wrote:
Peter Kümmel wrote:
Peter Kümmel wrote:
-       controller().clearParams();
+//     controller().clearParams();

Is also fixes my aspell crash

The crash is fixed indeed, but there is still an endless message box loop.


Hum... the call to dialog().CancelButton() seems superfluous in ControlSpellchecker::checkAlive(). That may well be the cause of your crash. Could you please try out this patch? If it works then it can easily be backported to 1.4.

But I still don't understand why I don't see a crash...

Abdel.
Index: ControlSpellchecker.C
===================================================================
--- ControlSpellchecker.C       (revision 14891)
+++ ControlSpellchecker.C       (working copy)
@@ -260,6 +260,12 @@
 
 bool ControlSpellchecker::checkAlive()
 {
+       if (!speller_.get()) {
+               Alert::error(_("The spellchecker controller has been killed\n"),
+                       _("Looks like a bug, please contact [EMAIL 
PROTECTED]"));
+               return false;
+       }
+
        if (speller_->alive() && speller_->error().empty())
                return true;
 
@@ -271,8 +277,6 @@
                message = _("The spellchecker has failed.\n")
                        + speller_->error();
 
-       dialog().CancelButton();
-
        Alert::error(_("The spellchecker has failed"), message);
        return false;
 }

Reply via email to