Angus Leeming wrote:
The "const" in "bool const foo" isn't needed/wanted in the header, only in the .C file. Think of it as an implementation detail. No doxygen comments.
ok
What does the updateonly do?
only the update() call (and not the action() ), that is: enable/disable the widget
While you're at it, it should be "std::string const & tooltip = std::string()".
will change that while i am at it...
Urgggsss. This kind of hard coding is really nasty. The info should go in the .ui files somehow.
i guess you are referring to this:
+ if (func.action==LFUN_TABULAR_INSERT) {
thing is, i am not going to create this widget for the other frontends. i think that if we are going to put it in the .ui files we would need special casing in the other frontends, but perhaps i am wrong. i also think there is no big difference with hardcoding like this:
>> case ToolbarBackend::MINIBUFFER: but then again, i have never hidden my ignorance... thanks, edwin
