Abdelrazak Younes a écrit :
Edwin Leuven a écrit :
Abdelrazak Younes wrote:
I agree it's overkill and we already discussed at length the subject.
But all other dialogs go through this controller framework so I would
prefer that you use that. Besides, I suspect that the change would be
even less intrusive if you do so. No need need to touch the QLToolbar
code at all, just replace the "add-table" dialog call with the
InsertTableWidget one.
the attached slightly modifies qlaction and avoids changing qltoolbar.
opinion?
I see in your patch that QLToolbar _is_ modified.
i also guess we need to keep the add-table dialog call for when the
user chooses to insert a table through the menu...
Then create a new LFUN (maybe LFUN_TABULAR_ICON_INSERT). Or
automatically detect in the other add-table dialog if the caller is a
menu item or an icon and transfer your code there.
Hum... thinking more about it, you could as well reuse the same QLAction
for the menu item call. I don't think the present dialog version provide
any more functionality than what you are proposing. I mean, it's not
like one will want to insert a 100x100 table, this just doesn't make sense.
Abdel.
