Edwin Leuven a écrit :
Angus Leeming wrote:
only the update() call (and not the action() ), that is: enable/disable
the widget
See my other mail. I think you should try to reuse that part also.
While you're at it, it should be "std::string const & tooltip =
std::string()".
will change that while i am at it...
Good, thank you.
Urgggsss. This kind of hard coding is really nasty. The info should go
in the
.ui files somehow.
i guess you are referring to this:
+ if (func.action==LFUN_TABULAR_INSERT) {
thing is, i am not going to create this widget for the other frontends.
i think that if we are going to put it in the .ui files we would need
special casing in the other frontends, but perhaps i am wrong. i also
think there is no big difference with hardcoding like this:
>> case ToolbarBackend::MINIBUFFER:
This one is special in the sense that it is not an icon but an edit box.
I agree nevertheless that we should find a more general way to add this
kind of control. So eventually this one special case should go also.
but then again, i have never hidden my ignorance...
I do that myself sometimes (hide my ignorance)... ;-)
Thanks,
Abdel.
