>>>>> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Abdelrazak> Georg Baum a écrit : >> Am Samstag, 8. April 2006 17:45 schrieb Bo Peng: >> >>> What I need from you, more experienced lyx developers, is a quick >>> look at the patch, find logic errors (like JMarc did for my >>> auto-cls-layout patch), design flaws (like the bundling of >>> lastfile with lastpos), or better implementations. >> This is the real problem, not the branch. I would have had a look >> if I had time. This won't improve with another branch. Abdelrazak> On the other hand, what would improve is the visibility of Abdelrazak> this patch. No. Now that the auto-layout patch is applied, I have no visibility on it anymore. I do not care about how well it works (OK, I am exagerating...). I care about how it is done, what parts of the code is affected and what parts have been forgotten. Actually, I have visibility, I can grab the patch again from svn! From my side, the fact that the patch is in means more work. There is a great risk that the feature will remain somewhat unfinished (all the corner cases) and that in 1.5 we will have people complaining that we release something that is not really tested. Abdelrazak> What would improve also is the visibility of the review Abdelrazak> process. With better visibility, you get more developer Abdelrazak> interested and as a consequence more developer with enough Abdelrazak> knowledge to review the patch. And, last but not least, Abdelrazak> others can help improving the patch (reviewer included). This is what I would give as advantage of sending patches :) JMarc
