>>>>> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
Martin> Jean-Marc, I think this is the version of reference to review. Martin> (Do we still make 1.4.0, or shall we play safe? But it's quite Martin> irritating as it is. Do we want the possible embarrassment or Martin> the certain annoyance?) There are some things that kind of annoy me (and no, I did not try it! I want to guess what could go wrong). 1/ could you describe how current font is used now? I thought it was only useful when inserting new text (font at cursor position) and now I do not know anymore. 2/ instead of LyXText::bufferFont, I would have preffered a real Buffer::defaultFont. At least is makes it clear that the font is the same for all LyXTexts in the same buffer. 3/ getFirstFontSettings could maybe have a BufferParam as parameter instead of directly a language (less risk of passing a bogus value). 4/ what is the use of noFontChange now? JMarc
