Why +2 for insets and +1 for normal text? I'd prefer

Martin Vermeer wrote:

> -        void paintForeignMark(double orig_x, LyXFont const & font);
> +        void paintForeignMark(double orig_x, LyXFont const & font, int
> desc = 1);

  desc = 0);

> -        int const y = yo_ + 1;
> +        int const y = yo_ + desc;

  +        int const y = yo_ + 1 + desc;

> -                paintForeignMark(orig_x, orig_font);
> +                paintForeignMark(orig_x, orig_font,
> +                        par_.getInset(pos)->descent() + 2);

  +                        par_.getInset(pos)->descent());


Apart from that, I like it.

Georg

Reply via email to