Martin Vermeer wrote:
On Sat, Jan 28, 2006 at 08:18:24PM +0100, Lars Gullik Bjønnes wrote:
Martin Vermeer <[EMAIL PROTECTED]> writes:
| Here corrected patch.
I actually like this patch, it makes things clearer, and fixes some
mistakes that look pretty obvious now. _But_ I also see that danger
that this changes user visible things, and perhaps not to the better
in all cases since there might be a spot or two that still needs
updating.
If this is to go into 1.4.0 it really needs som pretty hard
pounding.
What I am worried about is not so much the user-visible stuff, which is
a mess right now, and will be less messy with this patch. So what if it
doesn't handle some corner cases (I am not aware of any though).
No, the danger i see with this patch, and what I tried to test for, is
an implicit change in file format. E.g., if you have a LyX file looking
like this
\lang Norsk
(text a)
\begin_inset ...
(text b)
\lang Swedish
(text c)
\lang Norsk
(text d)
\end_inset
...is (text b) supposed to be in Norwegian, or in the buffer language
(was: default language)? I half expect existing documents to suffer some
implicit language changes because of this.
I don't think you should worry too much about this, for two reasons:
1. If there are any places with very subtle language
changes then those probably are the places were older cvs lyx-1.4
messes up badly anyway.
2. If anyone use cvs lyx-1.4 then they have to deal with changes and minor
breakage. They are betatesters. As long as a multilingual lyx 1.3
documents converts correctly, no problem.
Helge Hafting
