On Sat, 2004-10-02 at 15:40, Lars Gullik Bjønnes wrote:
> |     vector<string> types = controller().getTypes();
> 
> does getTypes() return a copy or a reference?

/// Return the list of types available
std::vector<std::string> const getTypes() const;

> Why do you need the rowindex?
> You can find out before the loop if there are entries or not.
> either by just checkint the size of the vector, or by comparing it and
> end.
Yeah, already picked up on that one while I was tidying in response to
Angus's comments.

> |     // Because tiny empty ComboBoxes just look silly
> |     typecombo_->set_size_request(typelistempty_ ? 130 : -1, -1);
> 
> make the 130 have a name
> 
>      int const emptyszie = 130;
Done.

> Should that string be translated?
Yes.  Am I right in thinking that to make a string translatable I just
enclose it in _() and let the internationalisation package detect it
later?

Now that I think of it, the glades will also need translating: will the
procedure be to just add their filenames to POTFILES.in?  (I read that
intltool supports glade xml files).

John

Reply via email to