John Spray wrote:

> Hi,
> 
> Attached: GTK+ Table of Contents dialog.  Let the code critique begin!
> :-)

:-)

GToc.C

Why not change this:
        int rowindex = 0;
        for(;it != end; ++it) {
                ...
                ++rowindex;

to:
        for (int rowindex = 0; it != end; ++it, ++rowindex;) {

The second block seems to overwrite the "if (contents.empty())" block?

        if (contents.empty()) {
                tocstore_->clear();
                (*tocstore_->append())[listCol_] = "*** No Lists ***";
                tocview_->set_sensitive(false);
                return;
        }

        // Okay, we're definitely going to put stuff in now
        changing_views_ = true;
        tocview_->set_sensitive(true);
        tocstore_->clear();

-- 
Angus

Reply via email to