Angus Leeming wrote: > > Angus, it works very well. Now only the off-by-one error is still > > there. > > Before we address that one,
which seems to be a qt issue btw. (incidentally, there seem to be some dispatch problems in xforms; opening the citation dialog from an inset is a real pain). > here's another clean-up patch. This one > stores a biblio::CiteEngine variable in BufferParams so that we no > longer need all this internal conversion between biblio::CiteEngine > and the tree bools use_natbib, use_jurabib and > use_numerical_citations. > > All seems to be well, but I'd value some testing from you too. Very well done, Angus. This new scheme is much cleaner and more straightforward than the old one. I cannot detect any drawbacks, so I'd say shove it in. Regards, Jürgen. PS I apologize for not being more helpful ATM. Real work...
