Juergen Spitzmueller wrote: > Angus Leeming wrote: >> Could you check it out, please? If all is well I guess that it can >> be backported to 1.3.x. > > Angus, the output of the first two entries in the combox is > reversed. I.e., the first entry (labelled [#ID]), produces \citet, > which is "Name [#ID]". The second, labelled Name [#ID], produces > \citep, which is [#ID].
Ok, I'll revert the patch in my tree and try and sort out the issues you describe below. > I have detected another problem wrt jurabib/natbib (introduced by > me): In Jurabib, I have added an extra entry (\cite, which produces > Name/<content of "before">). But when I switch from natbib to > jurabib, clicking on the insets shows the wrong style (off by one). > Any idea what to do on this? Will have a go. > Finally, since jurabib does not support numerical styles, jurabib > and numerical should be mutually exclusive (currently there is a > problem when switching from Jurabib/numerical to natbib). Ok, then we should define enum CiteType { PLAIN, NATBIB_AUTHORYEAR, NATBIB_NUMERICAL, JURABIB }; and use it rather than this hodge-podge of bools. Thanks for the feedback, -- Angus