Alfredo Braunstein wrote: > Angus Leeming wrote: > >> Alfredo Braunstein wrote: >> >>> This patch sanitizes selection handling. >>> Basically removes all InsetText special case selection-handling >>> code and adjust the LyXText code a bit to handle also insets. >> >>> Comments? >> >> Between you, you are making this stuff understandable. I'm not sure >> I approve. > > I'm not sure I understand what you are saying.
I was being silly. It's Friday. > Let me re-explain the purpose of the patch: LFUN_MOUSE_* are handled > independently by InsetText (on insets) and LyXText (on the main > text) by two similar code pieces of code. > The event belongs clearly to LyXText, so I think that the InsetText > code is redundant, modulo generalizing the LyXText code a bit. Is > this reasonable? Entirely. Hence "you are making this stuff understandable". > Said that, I recently realized that this patch is not fully correct, > (a problem with absolute vs. relative coordinates). In any case, I > still think that the idea is feasible. What do you think? I agree with you. Moreover, this last problem will just go away when you go down the "use absolute coords for this sort of stuff internally" route that you proposed the other day. -- Angus
