Angus Leeming wrote:

> Alfredo Braunstein wrote:
> 
>> This patch sanitizes selection handling.
>> Basically removes all InsetText special case selection-handling code
>> and adjust the LyXText code a bit to handle also insets.
> 
>> Comments?
> 
> Between you, you are making this stuff understandable. I'm not sure I
> approve.

I'm not sure I understand what you are saying. 
Let me re-explain the purpose of the patch: LFUN_MOUSE_* are handled
independently by InsetText (on insets) and LyXText (on the main text) by
two similar code pieces of code.
The event belongs clearly to LyXText, so I think that the InsetText code is
redundant, modulo generalizing the LyXText code a bit. Is this reasonable?

Said that, I recently realized that this patch is not fully correct, (a
problem with absolute vs. relative coordinates). In any case, I still think
that the idea is feasible. What do you think?

Alfredo


Reply via email to