On Tue, Jul 08, 2003 at 10:44:08AM +0200, Andre Poenitz spake thusly:
>
> On Tue, Jul 08, 2003 at 11:55:04AM +0300, Martin Vermeer wrote:
> > if (it->inset) {
> > if (static_cast<InsetBranch*>
> > (it->inset)->lyxCode() ==
> > Inset::BRANCH_CODE) {
>
> This first static_cast<InsetBranch*> is somewhere between superflous and
> wrong...
Superfluous and thus wrong. Cruft from an earlier attempt where the
.type member was tested, which only existed in a branch inset.
> > +
> > +
> > + InsetNote(BufferParams const &, string const &);
> > + /// Copy constructor
> > + InsetNote(InsetNote const &);
> > + ///
> > + ~InsetNote();
> > + ///
>
> Indentation.
>
> > + ///
> > + void read(Buffer const * buf, LyXLex & lex);
> > + ///
> > + void setButtonLabel();
> > + ///
> > + dispatch_result InsetNote::localDispatch(FuncRequest const &);
> > + ///
> > + int latex(Buffer const *, std::ostream &,
> > + LatexRunParams const &) const;
>
> Indentation.
>
> > void init();
> > + ///
> > + InsetNoteParams params_;
> > +};
>
> Indentation.
>
> > void FormNote::build()
> > {
> > dialog_.reset(build_note(this));
> >
> > fl_addto_choice(dialog_->choice_type, predefineds().c_str());
> >
> > bcview().setOK(dialog_->button_ok);
> > bcview().setApply(dialog_->button_apply);
> > bcview().setCancel(dialog_->button_cancel);
>
> Indentation, but seemingly not your doing.
You're too gracious. Cut'n paste with middle mouse button?
> > void FormNote::apply()
> > {
> > string const type = fl_get_choice_text(dialog_->choice_type);
> >
> > controller().params().type = type;
> > }
>
> Same. Would even fit on a line:
>
> > void FormNote::apply()
> > {
> > controller().params().type = fl_get_choice_text(dialog_->choice_type);
> > }
>
> Apart from that it doesn't look bad...
Okay, I have all that corrected in my tree. Thanks!
> Andre'
Martin
pgp00000.pgp
Description: PGP signature
