On Tue, Jul 08, 2003 at 11:55:04AM +0300, Martin Vermeer wrote:
> if (it->inset) {
> if (static_cast<InsetBranch*>
> (it->inset)->lyxCode() ==
> Inset::BRANCH_CODE) {
This first static_cast<InsetBranch*> is somewhere between superflous and
wrong...
> +
> +
> + InsetNote(BufferParams const &, string const &);
> + /// Copy constructor
> + InsetNote(InsetNote const &);
> + ///
> + ~InsetNote();
> + ///
Indentation.
> + ///
> + void read(Buffer const * buf, LyXLex & lex);
> + ///
> + void setButtonLabel();
> + ///
> + dispatch_result InsetNote::localDispatch(FuncRequest const &);
> + ///
> + int latex(Buffer const *, std::ostream &,
> + LatexRunParams const &) const;
Indentation.
> void init();
> + ///
> + InsetNoteParams params_;
> +};
Indentation.
> void FormNote::build()
> {
> dialog_.reset(build_note(this));
>
> fl_addto_choice(dialog_->choice_type, predefineds().c_str());
>
> bcview().setOK(dialog_->button_ok);
> bcview().setApply(dialog_->button_apply);
> bcview().setCancel(dialog_->button_cancel);
Indentation, but seemingly not your doing.
> void FormNote::apply()
> {
> string const type = fl_get_choice_text(dialog_->choice_type);
>
> controller().params().type = type;
> }
Same. Would even fit on a line:
> void FormNote::apply()
> {
> controller().params().type = fl_get_choice_text(dialog_->choice_type);
> }
Apart from that it doesn't look bad...
Andre'
--
Those who desire to give up Freedom in order to gain Security, will not have,
nor do they deserve, either one. (T. Jefferson or B. Franklin or both...)
