On Wed, Jul 09, 2003 at 09:34:45AM +0200, Juergen Spitzmueller spake thusly:
> Martin Vermeer wrote:
> > Note patch committed! (and I didn't forget the changelog :)
>
> Some comments:
>
> 1. greyedout code is still wrong.
> You are using
> \textcolor[gray]{0.8}{<content>
> }
> which breaks latex as soon as you have more than one paragraph (or a
> non-standard paragraph).
> Use
> \color[gray]{0.8}
> <content>
> \normalcolor
> instead.Oops. Patch attached. OK to go in? > 2. It would be nice to have an lfun with argument > note-insert [note|comment|greyedout] > (I'd like to use comment as default). Yes, wouldn't it :-) I'll keep it in the back of my mind. > 3. Probably a visual distinction between note and comment (yellow/magenta?) > would be nice. BTW though this is not your doing, yellow text on grey > background (i.e. the button) is not what I'd call readable (or even, what it > is supposed to be, eye catching). Yellow on grey is *awful*. The yellow is surely from the association with MMM Post-It (TM). Actually why a distinction? They are a lot more similar than different. Compared to footnote, branch etc, etc. that is. > Regards, > Juergen. > t. Martin
Index: insetnote.C
===================================================================
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/insets/insetnote.C,v
retrieving revision 1.27
diff -u -p -r1.27 insetnote.C
--- insetnote.C 8 Jul 2003 14:19:25 -0000 1.27
+++ insetnote.C 14 Jul 2003 18:20:58 -0000
@@ -143,7 +143,7 @@ int InsetNote::latex(Buffer const * buf,
int i = 0;
if (pt == "Comment") os << "%\n\\begin{comment}\n"; // remember to validate
- if (pt == "Greyedout") os << "%\n\\textcolor[gray]{0.8}{";
+ if (pt == "Greyedout") os << "%\n\\color[gray]{0.8}";
if (pt != "Note") {
i = inset.latex(buf, os, runparams);
}
@@ -152,7 +152,7 @@ int InsetNote::latex(Buffer const * buf,
i += 3;
}
if (pt == "Greyedout") {
- os << "%\n}";
+ os << "\\normalcolor%\n}";
i += 2;
}
return i;
pgp00000.pgp
Description: PGP signature
