On Wed, Mar 05, 2003 at 04:36:30PM +0100, Alfredo Braunstein wrote: > * rename LyXText::first_y to first_y_ and make it private. > * add a first_y() const method that returns first_y with some adjustment > * add a set_first_y(int newy) method > > Putting set_first_y(int newy) to assign first_y_ = newy and first_y() to > return first_y_ would reproduce the old behaviour. (In fact, up to here I > think it would be a sane change no matter what) > > What we do in the patch instead is to select a reference row (in > set_first_y) and return first_y_ plus the variations of this reference row. > The reference row is selected as the cursor row, but I think it would be > better to select the first visible row or somethig.
Does this mean first_y_ will be a pixel offset from this row ? If so, it needs renaming. If not, why not ? I would prefer "top_row_" and "top_row_offset_" renaming, or something similar. But this certainly sounds like a good idea/cleanup. > * Is there someone interested in this type of behaviour Hell yes. The only way we can slay the lyxtext dragon is by small steps. Let's right a war of attrition and let's win :) john
