Angus Leeming wrote: >> * rename LyXText::first_y to first_y_ and make it private. >> * add a first_y() const method that returns first_y with some adjustment >> * add a set_first_y(int newy) method > > Why not call them first_row() and set_first_row(int newrow). It might help > future generations a little ;-)
But I don't think that we want to lose the ability to make lyxtext show itself starting at a half-row for instance. Right now first_y() and set_first_y(int newy) still return and take an y-pixel-coordinate argument. It's only that this value is not fixed, but adjusted to text changes. The fact that I use rows for fixing the reference is is not crucial (in fact, it is somewhat broken: if a previous row gets eliminated because of rebreaking, we will see a one-row jump on screen. Maybe the right solution would be to take a "cursor position" as a reference --not the actual real cursor position, but say the first allowed visible cursor position. Or some cursor position in the middle of the screen). What do you think? PS: Sorry if I'm not being clear. Please tell me if it's not understandable. > > Don't forget xforms ;-) > Oops, you are right. Alfredo
