On Tue, Aug 20, 2002 at 11:24:10AM +0200, Jean-Marc Lasgouttes wrote: > > >>>>> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > >> Perhaps InsetOptionalArg is a better name than InsetShortTitle. > > Martin> Great plans, haven't we? :-) > > It may be wise to rename it now indeed. Several document classes for > example use optional arguments in their title fields, and we may want > to support them. We may want later to have the label of the inset > settable from layout file.
Hmmm... perhaps. But do you think it is wise to use a name that requires
an understanding of the LaTeX commands? Anyway, as you see the inset
label is 'opt' so in fact we are already in this situation... feel free
to change the name.
> Would you be so kind to rename InsetShortTitle to
> InsetOptionalArgument (or something else of your choice)? The right
> time for doing it is definitely now...
Find/replace... no big deal. Should I also change insetshorttitle.[Ch]?
> A couple remarks also:
>
> - if you want to keep InsetShortTitle::draw commented out, add a
> comment one what it is supposed to do
No, just delete it. A cut&paste artefact.
> - it seems to me that latexOptional should pass the last bool (free
> spacing) to the insettext's latex method. Ignoring the other bool
> (fragile) is right IMO, but then you should remove the name of the
> variable from the argument list to avoid a warning.
That was one thing I wanted to ask about. Didn't understand them, so
just left them alone. OK.
> And a few things you may want to do later:
>
> - document HasOption in Customization.lyx
>
> - make sure that HasOption also works with latex environments
>
> - allow to set the label of the inset from the layout file ("short
> header", "short caption", whatever)
>
> - document the feature in lyx doc
>
> - change the TOC code to actually use the short versions when
> available (in src/toc.* and src/insets/insetfloat.*).
Hmmm yes. Will be easier once this code is in CVS.
> Then you will deserve a new entry in CREDITS :)
What other reason do you think I have for putting up with the lot of you :)
> JMarc
>
Martin
msg43158/pgp00000.pgp
Description: PGP signature
