>>>>> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
>> Perhaps InsetOptionalArg is a better name than InsetShortTitle.
Martin> Great plans, haven't we? :-)
It may be wise to rename it now indeed. Several document classes for
example use optional arguments in their title fields, and we may want
to support them. We may want later to have the label of the inset
settable from layout file.
Would you be so kind to rename InsetShortTitle to
InsetOptionalArgument (or something else of your choice)? The right
time for doing it is definitely now...
A couple remarks also:
- if you want to keep InsetShortTitle::draw commented out, add a
comment one what it is supposed to do
- it seems to me that latexOptional should pass the last bool (free
spacing) to the insettext's latex method. Ignoring the other bool
(fragile) is right IMO, but then you should remove the name of the
variable from the argument list to avoid a warning.
And a few things you may want to do later:
- document HasOption in Customization.lyx
- make sure that HasOption also works with latex environments
- allow to set the label of the inset from the layout file ("short
header", "short caption", whatever)
- document the feature in lyx doc
- change the TOC code to actually use the short versions when
available (in src/toc.* and src/insets/insetfloat.*).
Then you will deserve a new entry in CREDITS :)
JMarc
