On Friday 16 August 2002 2:25 pm, Jean-Marc Lasgouttes wrote: > >>>>> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: > > Angus> On Friday 16 August 2002 2:19 pm, Andre Poenitz wrote: > >> On Fri, Aug 16, 2002 at 01:57:32PM +0100, Angus Leeming wrote: > So > >> we would lose lazy construction. > >> > >> What was this good for anyway? To reduce startup time? > > Angus> Conceptual elegance? Reducing compile times? Lars knows. A > > Wasn't it the fix to crashes with gcc 2.96?
No, his changes to Dialogs* predate that to the days of Porto and his desire for guiapi.C. The resulting code moved the dialog creation out of Dialogs (where it belongs IMO) and into guiapi.C. The implementation he employed used singleton classes to store the individual dialogs. The problem with this is that it means that we're limited to only one dialog of each type. Allan origianlly conceived of per-LyXView dialogs, which I think is more elegant too. He'll readily admit that his solution was not optimal (read kludgy and partial) and that it needed some work. My solution(s) are clean, but appear more expensive in terms of compile times. I therefore offer you two alternative implementations. Angus
