On Wed, 5 Dec 2001, John Levon wrote: > On Wed, Dec 05, 2001 at 04:56:38AM +0000, John Levon wrote: > > > using bv_->text means only a selection in the top-level is found. There might > > be an inset whose ->getLyXText() has a selection, but we won't find it like above. > > erk. > > insert file as ascii lines won't insert into an inset either. > > We need an audit of every single line that bv->text instead of bv->getLyXText > and assert its correctness. Making bv->text private is definitely the way to go ...
Okay so there are currently 241 matches to '>text[, ;-)]' in 27 files (146 of which are in BufferView_pimpl.C). Unfortunately only a handful are false positives -- like the two hits in frontends/xforms/FormSpellchecker.C. The hits in frontends/gnome/ and frontends/kde/ can be ignored because they are either commented out or the code has been abandoned (kde). So that just leaves: buffer.C:3 bufferview_funcs.C:2 BufferView_pimpl.C:146 figureForm.C:12 insets/inset.C:3 insets/insetert.C:1 insets/insetgraphics.C:1 insets/insetlabel.C:2 insets/insettabular.C:16 insets/insettext.C:3 insets/insetcollapsable.C:2 lyx_cb.C:5 lyxfind.C:1 lyxfunc.C:2 LyXView.C:1 mathed/formulamacro.C:1 paragraph_pimpl.C:1 screen.C:7 text2.C:5 text.C:2 undo_funcs.C:14 vspace.C:1 Of course there are also a swag of places in BufferView2.C that access text directly but they should all be okay (hopefully). Allan. (ARRae)
