Andre Poenitz <[EMAIL PROTECTED]> writes:

| > Mathed should _now_ play with what is present. Mathed should not
| > impose any huge changes to the the rest of LyX at _this_ stage.
| 
| Have you looked at the BufferView_pimpl.C change in mathed93.diff?
| 
| 
| I am moving the 50 LFUN_MATH* lines from the big switch into mathed.
| 
| I have removed two #include's for the preice of one external function
| definition.

external function definitions in .C file is bad, should always be in
.h files.
 
| I have to touch BufferView_pimpl.C anyway to fix one of the bugs.

yes?
  
| This does _not impose ANY changes to the the rest of LyX_, let alone 'HUGE'
| changes.

Muddles logic a bit.

Seems to me that the only reason why you do this changes is so that
you don't have to look at the lyxfunc.C or BufferView_pimpl.C files...

-- 
        Lgb

Reply via email to