John Levon <[EMAIL PROTECTED]> writes:

| 
|http://sourceforge.net/tracker/index.php?func=detail&aid=429678&group_id=15212&atid=115212
| 
| this is because :
| 
|     869                         string const s1 = _("Saving document") + ' '
|     870                                 + MakeDisplayPath(owner->buffer()->fileName()
|     871                                                   + "...");
| 
| in lyxfunc.C won't work as the const char * _() will be chosen (contrary to my
| comment in the bug, this affects the NLS build).
| 
| The simple fix is adding string(_("Saving document")) at that point
| 
| However, is there a better fix which will catch these in the future
| ? I'm rather 
| concerned this compiled without even a warning. We could have things
| like this 
| all over the place :/

IMHO the better fix is to use stringstreams:

ostringstream s1;
s1 << _("Saving document") << ' '
   << MakeDisplayPath(owner->buffer()->fileName())
   << "...";

This also reduces the amount of temporaries needed.

-- 
        Lgb

Reply via email to