On Sun, Jan 03, 2016 at 09:02:40AM +0000, Guenter Milde wrote: > On 2016-01-03, Scott Kostyshak wrote: > > On Sat, Jan 02, 2016 at 09:10:40PM +0000, Guenter Milde wrote: > >> On 2015-12-20, Guenter Milde wrote: > >> > On 2015-12-19, Jürgen Spitzmüller wrote: > >> >> Am Mittwoch 16 Dezember 2015, 20:35:27 schrieb Guenter Milde: > > ... > >> >> Probably an oversight. I agree that polyglossia should be preferred > >> >> now for all LuaTeX ouput (with fontspec). > > >> > This means we only have to check for "useNonTeXFonts" > >> > (polyglossia is already used for all XeTeX output). > > >> The following patch will auto-select polyglossia with fontspec whenever > >> possible. > > >> OK to commit? > > > Are there any differences in the test results? I forget---you are able > > to run the tests right? At some point I remember you could not run them > > but I think we figured it out. > > There are differences. The augmented patch includes what I think will be the > changes and the reasons. However, I did not run the tests.
I think there are some differences that you did not predict. Here are the differences between a69d6496 and a69d6496+your_first_patch. That is, I did not apply your patch that involves changing the test labels (which is clear because many of the differences are the 'hu' and 'id' tests which I think your newer patch addressed): > 219:INVERTED.AUTOTESTS.MULTILINGUAL_export/export/TableErrorIfSlovakTextInserted_dvi3_systemF 3a5 > 586:MANUALS_export/doc/de/Customization_dvi3_systemF 4a7 > 730:MANUALS_export/doc/es/Customization_dvi3_systemF 11a15,26 > 886:MANUALS_export/doc/fr/Customization_dvi3_systemF > 994:MANUALS_export/doc/fr/UserGuide_dvi3_systemF > 1018:INVERTED.MANUALS.TODO_export/doc/gl/Tutorial_dvi3_systemF > 1054:INVERTED.MANUALS.LYXBUGS_export/doc/hu/Intro_dvi3_systemF > 1066:INVERTED.MANUALS.LYXBUGS_export/doc/hu/Tutorial_dvi3_systemF > 1078:INVERTED.MANUALS.LYXBUGS_export/doc/id/Intro_dvi3_systemF > 1090:INVERTED.MANUALS.LYXBUGS_export/doc/id/Shortcuts_dvi3_systemF > 1102:INVERTED.MANUALS.LYXBUGS_export/doc/id/Tutorial_dvi3_systemF > 1191:MANUALS_export/doc/nb/Intro_dvi3_systemF > 1311:MANUALS_export/doc/sk/Intro_dvi3_systemF > 1395:INVERTED.MANUALS.TEXISSUES_export/doc/uk/Intro_dvi3_systemF > 1461:EXAMPLES_export/examples/H-P-statements_dvi3_systemF 19a35 > 2620:INVERTED.EXAMPLES.TODO_export/examples/es/ejemplo_con_lyx_dvi3_systemF 20a37 > 2710:INVERTED.EXAMPLES.TODO_export/examples/eu/adibide_lyx-atua_dvi3_systemF 32a50,54 > 2926:INVERTED.EXAMPLES.TODO_export/examples/gl/exemplo_lyxificado_dvi3_systemF > 2986:INVERTED.EXAMPLES.LYXBUGS_export/examples/hu/example_lyxified_dvi3_systemF > 2998:INVERTED.EXAMPLES.LYXBUGS_export/examples/hu/example_raw_dvi3_systemF > 3010:INVERTED.EXAMPLES.LYXBUGS_export/examples/hu/splash_dvi3_systemF > 3022:INVERTED.EXAMPLES.LYXBUGS_export/examples/id/splash_dvi3_systemF 39a62 > 3723:TEMPLATES_export/templates/kluwer_dvi3_systemF If you are OK with these other test failures and you think it is the right thing to do, then correct the test labels such that there shouldn't be any differences to test failures after your patch is applied. Post a new patch and I will confirm that nothing changes. Scott
signature.asc
Description: PGP signature
