Le 27/08/2015 02:12, Scott Kostyshak a écrit :
On Wed, Aug 26, 2015 at 8:42 PM, Guillaume Munch <ga...@free.fr>
wrote:
Anybody curious can test the patches (please) and make suggestions
while it is still on the stove. See more detail about the changes
in the commit messages.
I look forward to these improvements, Guillaume. Thanks for this
work! My only comment is that I would like to see better commit
messages. Your message for 0003 is great, your message for 0002 is
only one line (e.g. can you describe what is "better" about the
"better session management" ?), and your message for 0001 is OK
since you reference a bug and there are details in the bug report.
Normally I still like to see a message even if you reference a bug
number, but in this case it is pretty simple what you do. I would
also like to see your remark that highlighting is off by one in the
very last paragraph in the commit message.
In summary, I prefer for a patch/commit to be independent and
self-contained so that it withstands time (e.g. what if we change bug
trackers and our bug numbers become useless? This happened on one
project and it caused a lot of confusion.) and bad memories like mine
of discussions that happened on the list regarding the commit.
The above might just be my personal opinion. Perhaps others
disagree.
Scott
I am in entire agreement with you. I was worried that my message for
0003 was too long already... I changed the messages accordingly and will
send the new version after I get some feedback from other people.
For 0002, it is simply that the state of the widget is now entirely
remembered across sessions (we could do better and remember the settings
on a per-buffer basis, but that was enough for me).
For 0003, a bigger issue even is that it does not work for insets (this
is related to <http://www.lyx.org/trac/ticket/4725>). I believe that
this would be easy to fix if we let TexRow.cpp accept CursorSlices as an
argument for the conversion into lines (for the moment it segfaults if
we ask for certain non-toplevel paragraphs, like maths I believe, which
is why it only highlights top-level paragraphs). Either somebody
familiar with TexRow can have a look at this, or I will have to get into
it and CursorSlices (which do not look too difficult to understand)...
This would be a big improvement to the source panel.
Guillaume
