On Wed, Aug 26, 2015 at 8:42 PM, Guillaume Munch <ga...@free.fr> wrote:
> Anybody curious can test the patches (please) and make suggestions while it > is still on the stove. See more detail about the changes in the commit > messages. I look forward to these improvements, Guillaume. Thanks for this work! My only comment is that I would like to see better commit messages. Your message for 0003 is great, your message for 0002 is only one line (e.g. can you describe what is "better" about the "better session management" ?), and your message for 0001 is OK since you reference a bug and there are details in the bug report. Normally I still like to see a message even if you reference a bug number, but in this case it is pretty simple what you do. I would also like to see your remark that highlighting is off by one in the very last paragraph in the commit message. In summary, I prefer for a patch/commit to be independent and self-contained so that it withstands time (e.g. what if we change bug trackers and our bug numbers become useless? This happened on one project and it caused a lot of confusion.) and bad memories like mine of discussions that happened on the list regarding the commit. The above might just be my personal opinion. Perhaps others disagree. Scott
