On Mon, Apr 6, 2015 at 3:29 AM, Jürgen Spitzmüller <sp...@lyx.org> wrote: > Am Sonntag 05 April 2015, 12:38:14 schrieb Scott Kostyshak: >> For the LaTeX log, we still stop on first error in some cases. This >> results in having more incomplete PDFs than we could have if we still >> continued and did subsequent latex and bibtex runs. For example, open >> Tutorial.lyx, add an ERT \dafdsfds somewhere, and compile. Then press >> the "Show Output Anyways" button. All of the "See \ref" will be "See >> ??". >> >> In the code, we have the following chunk multiple times: >> >> if (scanres & ERRORS) >> return scanres; // return on error > > We should probably, like I did for bibtex, only return at the very end.
OK. >> And note that we overwrite scanres several times. So if we just remove >> the return statements, we might miss something. For example, is it >> possible to run LaTeX and there be an error, then run LaTeX again and >> there is not? I do not know of a case, but still our code should be >> aware of it. > > I cannot think of a case either. If the error disappears on the last latex > run, I'd consider it resolved. In this case the patch should be easy, just removing the return statements. I will do this and test. Scott
