On Sat, Apr 4, 2015 at 1:14 PM, Scott Kostyshak <skost...@lyx.org> wrote:
> On Sat, Apr 4, 2015 at 3:28 AM, Jürgen Spitzmüller <sp...@lyx.org> wrote:
>> Scott Kostyshak wrote:
>>> Good point. Attached is the updated patch, and the diff with respect
>>> to the first patch.
>>
>> I'd say commit it.
>
> Done at 09700d5b.
>
> Scott
Your patch for #2757 checks bscanres at the end now, which allows
compilation to continue in the chain.
For the LaTeX log, we still stop on first error in some cases. This
results in having more incomplete PDFs than we could have if we still
continued and did subsequent latex and bibtex runs. For example, open
Tutorial.lyx, add an ERT \dafdsfds somewhere, and compile. Then press
the "Show Output Anyways" button. All of the "See \ref" will be "See
??".
In the code, we have the following chunk multiple times:
if (scanres & ERRORS)
return scanres; // return on error
And note that we overwrite scanres several times. So if we just remove
the return statements, we might miss something. For example, is it
possible to run LaTeX and there be an error, then run LaTeX again and
there is not? I do not know of a case, but still our code should be
aware of it. So I propose to remove the return statements and instead
of overwriting our scanres variable, we create scanres1, scanres2,
scanres3. We then (at the end) check all of them for errors (and
return if any one has an error).
Any thoughts?
Scott
