On 10/09/2014 10:16 AM, Stephan Witt wrote:
Am 09.10.2014 um 16:04 schrieb Richard Heck <rgh...@lyx.org>:
On 10/09/2014 03:25 AM, Stephan Witt wrote:
Am 09.10.2014 um 00:25 schrieb Richard Heck <rgh...@lyx.org>:
* The BufferParams.display_pixel_ratio member will be set to the magnification
the app wants. This happens when the buffer is assigned to the work area. Not
as clean as I want but I couldn't come up with a better solution.
It seems to me that maybe this should be a member of BufferView. One could in
principle have the same buffer open in two windows on two different monitors,
no? I would suppose for the same reason that Buffer::fontScalingFactor should
be in BufferView, etc.
I agree - but how can the PreviewLoader access the BufferView?
In case of more than one - what is the right one then?
Yes, I see the problem. Preview loading is at the moment per Buffer. Long term,
maybe that needs to be changed. For now, could we try to find out what the
maximum resolution we need is and do that? Scaling the image down is presumably
easier.
This is exactly how it works with my patch. The maximum resolution is queried
from the GuiApplication.
Later it fits for the current screen or will be scaled down for lower
resolution.
OK, that sounds reasonable. I suppose we can see how it works and if we
need to do something more we can do it then.
Richard
