Am 09.10.2014 um 00:25 schrieb Richard Heck <rgh...@lyx.org>: > On 10/08/2014 11:48 AM, Stephan Witt wrote: >> Now I have an updated patch including hi-dpi preview and icons. It is >> really obfuscated now. I don't want to commit it as this monster patch. >> I'll try to explain it for review therefore… > > I don't have an HiDPI display so can't test this.
Thank you for reviewing it. >> * The BufferParams.display_pixel_ratio member will be set to the >> magnification the app wants. This happens when the buffer is assigned to the >> work area. Not as clean as I want but I couldn't come up with a better >> solution. > > It seems to me that maybe this should be a member of BufferView. One could in > principle have the same buffer open in two windows on two different monitors, > no? I would suppose for the same reason that Buffer::fontScalingFactor should > be in BufferView, etc. I agree - but how can the PreviewLoader access the BufferView? In case of more than one - what is the right one then? The value in BufferParams.display_pixel_ratio has "application scope". But this may change, I'm not sure. >> BTW: Does anyone know how to find all callers of a C++ method? I'm used to >> have this at hand when working with Eclipse and Java. I cannot find this >> feature neither in Eclipse for C++ nor in XCode. Is there any IDE with this >> functionality? Refactoring of code would be much more easy with this :( > > In QtCreator, if you go to any place the method is used or declared, you can > right click and then choose "Find Usages". That will give you what you want. Ok, thanks. But now I found this feature in XCode too. It was somewhat hidden - no menu entry and not in any context menu. It is changeable in the find area. Stephan
