On Tue, Oct 7, 2014 at 4:58 AM, Stephan Witt <st.w...@gmx.net> wrote: > Am 06.10.2014 um 22:05 schrieb Marcelo Galvão Póvoa > <marspeoples...@gmail.com>: > >> On Sun, Oct 5, 2014 at 4:29 PM, Stephan Witt <st.w...@gmx.net> wrote: >>> Am 02.10.2014 um 13:14 schrieb Stephan Witt <st.w...@gmx.net>: >>> >>>> Am 18.07.2014 um 10:39 schrieb Stephan Witt <st.w...@gmx.net>: >>>> >>>> I gave it a try to make some progress regarding the HiDPI stuff. >>>> >>>> First I've decided to split the task. I'd postpone the image scaling >>>> issues. >>>> Not only because of the dynamic nature of the preview rendering. It's a >>>> slightly >>>> more complex thing in general - we need to provide multiple image/icon >>>> sets for >>>> different pixel ratios, IMHO. >>>> >>>> My work is based on the first patch from Marcelo. I dropped the use of >>>> the global >>>> LyXRC member variable and made an alternate solution without it. >>>> >>>> See the attached patch. In principle it works. There is an issue with >>>> scrolling. >>>> The vertical scroll bar on a Mac is not visible all the time. Only while >>>> scrolling >>>> it is drawn and the content of the region under at the left side of the >>>> main text >>>> area is a duplicate of the middle of the text area on the stop of the >>>> scroll operation. >>>> See the attached screen shot. >>>> >>>> Stephan >>>> >>>> <0003-Add-basic-qt5-HiDPI-rendering-support.patch> >>>> <Bildschirmfoto 2014-10-02 um 13.04.08.png> >>> >>> Now I have an improved patch without the scrolling issue. I'd like to >>> commit it. >>> Are there any thoughts about it? >>> >>> Stephan >>> >> >> I tested your patch a little and I found some of the quirks I've been >> having when I worked with this: >> >> - Redrawing the cursor sometimes causes some drawing errors around >> characters. If I hold left/right arrow key to move the cursor across >> text, I get something like the attached screenshot. As I mentioned, my >> patch avoids partial viewport updates to workaround this, but it is >> not a decent solution. > > Sorry, I cannot reproduce your problem. Or I do not understand it. > You're talking about text navigation with cursor up/down, right? > What's the partial viewport update you're talking about? >
It mostly happens with cursor left/right. Please see this demo: https://dl.dropboxusercontent.com/u/20456192/cursor.mov To workaround this, my second patch essentially changes cursor drawing behavior from partial updates to full updates, like so: - p->viewport()->update(cursor_->rect()); + update(0, 0, p->viewport()->width(), p->viewport()->height()); Let me know if you can reproduce this. Marcelo > Stephan > >> - Instant Preview of math formulas is not rendered in HiDPI. My patch >> does this but has an ugly dependency on LyxRC. > >> - Dynamically changing window DPI (i.e, moving it between different >> screens) makes the text blurry. I haven't tested this much, but maybe >> it is related to some unflushed drawing cache? >> >> Marcelo >> <cursor.png> >
