On 28/04/14 08:48, Vincent van Ravesteijn wrote:
> Below are my opinions. Please read from bottom to top.
Hi,
thanks for these.
I see I definitely need a lyxchat3 rework before the merge.
I'll try to do that, but it will take one or a couple of weeks.
A few remarks:
-) Vincent suggests to create the new branch in features.git, so I'll ensure
the reworked patchset goes into a branch over there
-) I was expecting many late fixes to have to be merged to the first patch
from the beginning, I'll try to do that
-) possible concerns about distributing LyX: one such concerns may be due
to the fact that, in general, we add networking capabilities to LyX (this
may apply to the chat as well as to the interactive lyx feature); often
it's not enough to tell users that, until you don't use the chat, it won't
be able to hurt you; users might assume that now LyX is less secure
because it has a networking component, and if there's any bug, one
attacker might exploit a LyX weakness etc...
[ I'm especially thinking of a few people I know who use LyX to write
patent applications ]
So, one way to rule such concerns out, would be the one to have a
different executable: traditional lyx, with any networking feature
disabled at compile-time, versus collaborative lyx (e.g., with such
a name as "lyx-net" or similar), with said features enabled.
-) very good point the one to move GuiMessanger out of qt4, and s/Gui//
-) why the moc-ification of BufferView.h, and the QT_NO_KEYWORDS ?
I wish I remembered. Just, I was unable to compile otherwise, the
problem was due to pulling-in the QXMPP headers, I just found this
thread on lyx-devel explaining what happened at that time:
https://www.mail-archive.com/lyx-devel@lists.lyx.org/msg181164.html
any hint as to how to deal properly/better with this problem would be
appreciated.
-) is QXMPP available on Windows and Mac OS-X ? No clue! Windows and
Mac people, please speak, and/or try to compile the tommaso/features/chat2
branch on Windows and Mac, and let's try to chat and see whether it works.
As for Windows, there's at least this thread
https://code.google.com/p/qxmpp/issues/detail?id=93
where there's at least one user claiming it compiles and works fine on WinXP
32bit,
and the thread starter complaining about problems with Win7 x64.
Thanks, bye.
Tommaso
