On Mon, Apr 28, 2014 at 2:19 AM, Tommaso Cucinotta <tomm...@lyx.org> wrote: > On 20/11/13 14:01, Kornel Benko wrote: >> I like it. Feels good, especially on the fresh new window. To get it into >> master should be the first think after releasing 2.1 IMHO. Kornel > > That seems the right time then! > > Currently, this is a patchset of 21 commits > > > http://git.lyx.org/?p=developers/tommaso/lyx.git;a=shortlog;h=refs/heads/features/chat2 > > Guess Vincent might comment on whether these should be squashed into a > single commit or similar? > > T. > >
I wouldn't rush getting this into master. It would be nice to sort out a few issues that I see for now: - in config/qt4.m4 it seems to unconditionally pull in QtNetwork and QtXml. Is this really so ? - do we want to have a feature turned on by default that depends on yet another dependency ? - does it work on MacOSX ? Is libQXmpp installed by default on MacOSX ? Is it a problem to compile our own lib and supply it within the package ? Did anyone test it already on MacOSX ? - the same questions for Windows ? - do we want to include this feature and all dependencies by default ? Or supply separate binaries or whatever ? - does anyone have general objections or concerns ? Some more detailed remarks will follow. Vincent
