On Mon, Apr 28, 2014 at 2:19 AM, Tommaso Cucinotta <tomm...@lyx.org> wrote:
> On 20/11/13 14:01, Kornel Benko wrote: > > I like it. Feels good, especially on the fresh new window. To get it > into master should be the first think after releasing 2.1 IMHO. Kornel > > That seems the right time then! > > Currently, this is a patchset of 21 commits > > > http://git.lyx.org/?p=developers/tommaso/lyx.git;a=shortlog;h=refs/heads/features/chat2 > > Guess Vincent might comment on whether these should be squashed into a > single commit or similar? > Below are my opinions. Please read from bottom to top. 6 hours ago Tommaso Cucinotta Completed exclusion of chat from > GuiView when USE_QXMPP... features/chat2 commit | commitdiff | tree | > snapshot > Merge with first commit. > 6 hours ago Kornel Benko * sk.po commit | commitdiff | tree | > snapshot > This is not part of this feature. > 7 hours ago Tommaso Cucinotta Multi-view XMPP chat. commit | > commitdiff | tree | snapshot > Lose the "." in the commit subject. Further, I don't think that a Widget should read/write files. The core functionality of the messenger should be in "core" I guess. I'm not sure why GuiChatMessenger is called "Gui" and is in frontends/qt4 as it doesn't have a related dialog or the like. Why do you think it should be in frontends/qt4 ? > 7 hours ago Tommaso Cucinotta Missing file-level comment for > GuiChatMessenger.cpp. commit | commitdiff | tree | snapshot > Merge with first commit. > 7 hours ago Tommaso Cucinotta Polishing code, removing unused > functions, moving resid... commit | Merge with first commit. > commitdiff | tree | snapshot > 7 hours ago Tommaso Cucinotta whitespaces commit | commitdiff | > tree | snapshot > Merge with first commit. > 7 hours ago Kornel Benko Make some GUI strings translatable > commit | commitdiff | tree | snapshot > Merge with first commit. > 7 hours ago Tommaso Cucinotta LyX Chat - added a couple of missing > ifdefs in case... commit | commitdiff | tree | snapshot > Merge with first commit. > 7 hours ago Tommaso Cucinotta Switch to new latexclipboard > importing string format... commit | commitdiff | tree | snapshot > Merge with first commit. > 7 hours ago Tommaso Cucinotta Fix focus issue and add colors-based > distinction of... commit | commitdiff | tree | snapshot > Merge with first commit. > 7 hours ago Tommaso Cucinotta Make chat menu item disappear in case > of no QXMPP support. commit | commitdiff | tree | snapshot > Merge with first commit. > 7 hours ago Tommaso Cucinotta Fixed a few issues with id/resource > handling. commit | commitdiff | tree | snapshot > Merge with first commit. > 7 hours ago Tommaso Cucinotta Made string/question translatable. > commit | commitdiff | tree | snapshot > Merge with first commit. > 7 hours ago Kornel Benko Add option to cmake build for use (or not > use) of QXMPP commit | commitdiff | tree | snapshot > Merge with "Patch for compiling the QXMPP based chat with cmake..." > 7 hours ago Tommaso Cucinotta LyX Chat - Let's see if this RETURN > problem is fixed. commit | commitdiff | tree | snapshot > I don't want to see this type of commits. Either merge with the first commit, or explain exactly what the problem is that you try to fix here. Are you now sure whether it fixes the problem ? If so, remove the "Let's see", otherwise try to figure it out ;). > 7 hours ago Tommaso Cucinotta LyX Chat - add/remove buddy > capability, plus various... commit | commitdiff | tree | snapshot > Various bugfixes should be merged with first commit. I would prefer to either add the prefix "lyx-chat:" to all commits, or to none. > 7 hours ago Tommaso Cucinotta Fix compilation problem when > compiling without qxmpp. commit | commitdiff | tree | snapshot > Merge with the first commit. > 7 hours ago Tommaso Cucinotta Now presence icons are correctly > shown in my status... commit | commitdiff | tree | snapshot > Merge with the first commit. > 7 hours ago Tommaso Cucinotta store and retrieval of user's > password from .passwd... commit | commitdiff | tree | snapshot > Commit subject line should consist of a single line without dots. > 7 hours ago Tommaso Cucinotta Patch for compiling the QXMPP based > chat with cmake... commit | commitdiff | tree | snapshot > I propose the commit subject as: "lyx-chat: Compile QXMPP based chat with CMake". The "Patch for" and "by Kornel Benko" parts are not very informative for the subject. The change to GuiBuddies.h should be merged with the previous commit. > 7 hours ago Tommaso Cucinotta LyX XMPP Chat commit | commitdiff > | tree | snapshot > Vincent
