On 09/24/2011 08:40 AM, Liviu Andronic wrote: > Hello Philip > You clearly robbed me of the opportunity to try to provide my first > code-related patch for LyX. But I cannot be too mad: I wouldn't have > pulled it through. :) > > A few suggestions below: > > > 2011/9/24 PhilipPirrip <p...@net.hr>: >> qt_helpers.cpp >> Added support for "List of ERT's" >> > I would suggest "List of ERT insets". Alternatively, it could be "List > of ERTs" (without the apostrophe). > It's been suggested we drop "List of". That's worth considering, since they're all lists.
> I also thought that a "List of External Materials" (or similar) would > come in handy. I attach a tentative patch. I don't quite understand > the code, but I tried to follow the approach in your patches. > Unfortunately r39740 doesn't build here, so I don't know if my patch > messes anything up. Please inspect and let me know. > I'm starting to worry a little about how many things are in the TOC, mostly because calculating them may start to get expensive. We had problems like this before, when we were putting the entire text of a branch into the TOC. That's solved, but we could end up with a similar problem if there were a lot of other things in there. The solution, I'd think, would be to let users choose what appears in the TOC under Preferences. Richard
