On Sun, Sep 18, 2011 at 05:11:31PM +0200, Stephan Witt wrote:
> Am 18.09.2011 um 14:38 schrieb Enrico Forestieri:
>
> > On Sun, Sep 18, 2011 at 02:08:28PM +0200, Stephan Witt wrote:
> >
> >> We have at least two errors here:
> >> 1. the wrong default language is choosen
> >
> > I don't think so. If you start a latex file as
> >
> > \documentclass{article}
> > \begin{document}
> > \end{document}
> >
> > guess what the default language is.
>
> I tried to guess and I don't know it. Please, tell me the right answer.
It's English.
> If it is English, we can at least display "Default (English)" or something
> similar. It it is dynamically assigned I wouldn't present "Default" as
> default. The average user expect the GUI language as default, IMHO.
When creating a new document, Document->Settings->Language says "English".
> > If you really want to start in some
> > different language any new document, you could perform the language change
> > and save it as Document Defaults.
>
> That's right. But people did start complaining, that the spell checker cannot
> tell what language the text is and of course there is some real language when
> default is selected. If it's not defined, then the spell checker should skip
> that text fragments and if it is english it should be displayed as such at
> least.
I don't know what you are talking about. I cannot select a Default language,
but only actual languages in Document->Settings->Language.
> >> 2. the change of the text language is made by pure guessing and without
> >> asking the user what she wants to happen with the text language
> >
> > Not really. Any explicit change of language is honoured.
>
> I meant the implicit change when changing the document language. And I meant
> that the decision to change or not is made in a very non-transparent manner.
Yes, but without the patch. With the patch, any word not explicitly marked
in a given language gets updated, unless you are changing from LTR to RTL
languages or viceversa.
> >
> >> 3. I'm not sure if a "default" language makes sense at all
> >
> > I think so.
> >
> >> To correct this the check for isMultiLingual() should be replaced by a
> >> confirmation dialog were the user can decide, IMHO.
> >
> > Yet another bothering dialog to answer...
>
> How often do you change the document language? I think that every piece of
> software should work as silent as possible. But if there is something the
> user should decide it should be asked for.
I think that everyone expects that any word not explicitly marked with
a given language gets updated. So, this dialog would only be boring.
> But I agree here that the buffer_.isMultiLingual() part should go.
> If this is enough I'm not sure.
Ok. I will then commit the patch.
--
Enrico
