On 17-4-2011 17:59, Peter Kümmel wrote:
>
>>
>> - To translate the string I used tr("Search"), is that correct?
>
> We use gettext, there and also here underscore is common:
> _("Search");
The correct way in the frontends/qt4 part is to use qt_("Search") instead.
>
>> - Currently the widgets are highlighted in red, alternative ideas? Maybe
>> bold or
>> nothing at all.
I'm not sure. I don't like the red that much, but well, let's see how the patch
evolves.
>> - Do you think a "rubber" button in (or next to) the QLineEdit is necessary
>> to
>> clean the search box?
I've no clue what a "rubber" button is. But something to clear the field would
be useful.
>>
>> I should also add something to reset the search box when closing the dialog.
>> Apart from these (useful!) comments, does the patch work?
Yes, though it is a bit slow :(. We might want to look into that.
Vincent
