> > - To translate the string I used tr("Search"), is that correct?
We use gettext, there and also here underscore is common: _("Search"); > - Currently the widgets are highlighted in red, alternative ideas? Maybe bold > or > nothing at all. > - Do you think a "rubber" button in (or next to) the QLineEdit is necessary to > clean the search box? > > I should also add something to reset the search box when closing the dialog. > Apart from these (useful!) comments, does the patch work? > > venom00 > > P.S. Thanks for reviewing my patch! :) > > [1] irc://irc.freenode.org/Qt > >