On Mon, Feb 21, 2011 at 6:11 AM, Stephan Witt <st.w...@gmx.net> wrote: > Am 21.02.2011 um 10:59 schrieb Pavel Sanda: > >> Stephan Witt wrote: >>> + MetaModifier = 8 //< meta key held >> //for mac key XXX >> >>> - if (state & Qt::AltModifier || state & Qt::MetaModifier) >>> + if (state & Qt::AltModifier) >>> k |= AltModifier; >> >> isn't possible we are going to break something here on other archs? > > You told me only a mac and old suns have a meta key ;-) > > But seriously, the resulting code snippet is this one: > ====================== > if (state & Qt::AltModifier) > k |= AltModifier; > #ifdef USE_MACOSX_PACKAGING > if (state & Qt::MetaModifier) > k |= MetaModifier; > #else > if (state & Qt::MetaModifier) > k |= AltModifier; > #endif > ====================== > It's effectively the same for non-macs after all. > Alt- and Meta-Modifier will be mapped to KeyModifier::AltModifier. > >>> +#ifdef USE_MACOSX_PACKAGING >>> + if (state & Qt::MetaModifier) >>> + k |= MetaModifier; >>> +#else >>> + if (state & Qt::MetaModifier) >>> + k |= AltModifier; >>> +#endif >>> return k; >>> } >> >> otherwise look ok. > > Thanks, I'll wait a little bit for Bennett's reply.
I'm not entirely sure what the patch is supposed to do, but for the most part it seems to work. Except for <opt>[arrow-key], it looks like all keybindings that were formally <opt> have now been switch to <control>. Is there something else I should be testing? One problem here: The switch includes custom keybindings, which means that my keybindings have all of a sudden changed on me without warning, which is not something I think we should do to users, though I'm not sure how to handle the transition. (Fortunately, it's possible to change them back manually, but that's potentially a tedious hassle for some users like me who have many custom keybindings.) Another problem that I noted that I assume is unrelated to this patch: with the "Open documents in tabs" preference setting unchecked, I can no longer open two or more documents in the same window. (Formerly I could do this by selecting a "hidden" document from within an already open document.) I discovered this when trying to test <cmd><opt><left/right>, which I use (like on Firefox) to switch between tabs. Shall I create a separate bug report for this? BH
