Am 21.02.2011 um 10:59 schrieb Pavel Sanda:

> Stephan Witt wrote:
>> +    MetaModifier     = 8  //< meta key held
>                       //for mac key XXX
> 
>> -    if (state & Qt::AltModifier || state & Qt::MetaModifier)
>> +    if (state & Qt::AltModifier)
>>              k |= AltModifier;
> 
> isn't possible we are going to break something here on other archs?

You told me only a mac and old suns have a meta key ;-)

But seriously, the resulting code snippet is this one:
======================
        if (state & Qt::AltModifier)
                k |= AltModifier;
#ifdef USE_MACOSX_PACKAGING
        if (state & Qt::MetaModifier)
                k |= MetaModifier;
#else
        if (state & Qt::MetaModifier)
                k |= AltModifier;
#endif
======================
It's effectively the same for non-macs after all.
Alt- and Meta-Modifier will be mapped to KeyModifier::AltModifier.

>> +#ifdef USE_MACOSX_PACKAGING
>> +    if (state & Qt::MetaModifier)
>> +            k |= MetaModifier;
>> +#else
>> +    if (state & Qt::MetaModifier)
>> +            k |= AltModifier;
>> +#endif
>>      return k;
>> }
> 
> otherwise look ok.

Thanks, I'll wait a little bit for Bennett's reply.

Stephan

Reply via email to