On 12/04/2010 09:54 AM, Jürgen Spitzmüller wrote:
Jürgen Spitzmüller wrote:
Jürgen Spitzmüller wrote:
A patch along this line is attached. We still have to hardcode xhtml,
since there's no dedicated converter where we could derive a xhtml flag
from.
I committed the backend=flavor part, since this is a step forward anyway
and removes some bad hardcoding.
I come back to this. Attached is a reworked version of the view source part. I
have added a cache for the default flavor, since it is overkill to recheck for
the flavor on each key stroke.
Typing with full source on the UG is slow. But it is as slow without the
patch.
Yeah, it's always going to be slow. We're regenerating the whole thing
for every key stroke.
It's amazing you can type at all.
Objections?
My only question is one I think JMarc asked earlier, namely, whether we
want to provide some
mechanism for indicating flavor in some config file, rather than trying
to guess it.
Actually, one other thing. It occurs to me that, at the moment, the
XHTML output code doesn't
pay any attention to "nice" flag (or whatever it is that means:
preview). There's no need to generate
images, etc, when doing preview, and right now we would be. Do we want
to hold this patch until
I fix that, or do you want to commit it anyway, or do you want to commit
it but with the XHTML
preview stuff disabled? This is entirely up to you.
Nice work.
Richard
