Stephan Witt wrote:
> >> I'll use an explicit getRevisionInfo() success state flag and return
> >> string() instead. Ok?
> >
> > not sure what exactly do you mean :)
>
> That's how I understood your comment, but the new patch is not ready...
>
> Like that:
>
i'm basically happy that the duplicated strings disappeared.
lyxerr looks more approriate inside getRevisionInfo.
iirc svn used "?" hack for this, but do as you wish..
> string CVS::revisionInfo(LyXVC::RevisionInfo const info)
> {
> if (!version_.empty()) {
> if (!have_rev_info_) {
> if (!getRevisionInfo())
> LYXERR(Debug::LYXVC,
> "Could not retrieve revision info for "
> << version_ <<
> " of " << getTarget(File));
> have_rev_info_ = true;
> }
> switch (info) {
> case LyXVC::File:
> return version_;
> case LyXVC::Author:
> return rev_author_cache_;
> case LyXVC::Date:
> return rev_date_cache_;
> case LyXVC::Time:
> return rev_time_cache_;
> default: ;
> }
> }
> return string();
> }
>
>
> Stephan
