Am 04.11.2010 um 14:45 schrieb Pavel Sanda:
> Stephan Witt wrote:
>>>> string CVS::revisionInfo(LyXVC::RevisionInfo const info)
>>>> {
>>>> - if (info == LyXVC::File)
>>>> - return version_;
>>>> + if (!version_.empty()) {
>>>> + if (rev_author_cache_.empty()) {
>>>> + if (!getRevisionInfo()) {
>>>> + rev_author_cache_ = to_local8bit(_("unknown
>>>> author"));
>>>> + rev_date_cache_ = to_local8bit(_("unknown
>>>> date"));
>>>> + rev_time_cache_ = to_local8bit(_("unknown
>>>> time"));
>>>
>>> this code breaks the current practise - either we return true value or empty
>>> string in unknown case, which will be handled on the hierarchy above.
>>
>>> and i think i see latent translating bug in the handling code above. wanted
>>> to
>>> check it but why the hell LC_MESSAGES=cs_CZ src/lyx doesn't work anymore for
>>> trunk...
>>
>> I'll use an explicit getRevisionInfo() success state flag and return
>> string() instead. Ok?
>
> not sure what exactly do you mean :)
That's how I understood your comment, but the new patch is not ready...
Like that:
string CVS::revisionInfo(LyXVC::RevisionInfo const info)
{
if (!version_.empty()) {
if (!have_rev_info_) {
if (!getRevisionInfo())
LYXERR(Debug::LYXVC,
"Could not retrieve revision info for "
<< version_ <<
" of " << getTarget(File));
have_rev_info_ = true;
}
switch (info) {
case LyXVC::File:
return version_;
case LyXVC::Author:
return rev_author_cache_;
case LyXVC::Date:
return rev_date_cache_;
case LyXVC::Time:
return rev_time_cache_;
default: ;
}
}
return string();
}
Stephan
