Stephan Witt wrote: > Or I can go to rcs and you'll do the svn implementation?
i came to the conclusion that its less energy spent when i write the patch myself than doing detailed review and flame about nitpicks. please make documentation for the current cvs state inside additional manual and indicate to the users what are the supposed usecases. > > here is the superflous-dialog fix which is on the top of your first patch. > > it basically (should) not change behaviour of svn and rcs and let you do > > any > > bussiness inside cvs (i let the cvs routines in your version.) > > untested, i will get to the svn/rcs part later. > > Ok. I went to sleep yesterday. > I did commit the first patch now. > (with typo corrected and the unused method revertWithConfirmation() removed.) > > One general question: > What's the problem with the following construct? you mean why i changed it to the virtual function? generally no problem. in this particular case i changed the construct in order to be consistent with the rest of other code we use. pavel