Am 25.10.2010 um 00:53 schrieb Pavel Sanda:
> Pavel Sanda wrote:
>> the 2nd patch is not finished should i apply here and try to finish svn part
Yes, I know. But I did want to consolidate cvs before going to svn or rcs.
I'll have to setup a local svn repository to be able to test that - if you like.
Or I can go to rcs and you'll do the svn implementation?
>
> here is the superflous-dialog fix which is on the top of your first patch.
> it basically (should) not change behaviour of svn and rcs and let you do any
> bussiness inside cvs (i let the cvs routines in your version.)
> untested, i will get to the svn/rcs part later.
Ok. I went to sleep yesterday.
I did commit the first patch now.
(with typo corrected and the unused method revertWithConfirmation() removed.)
One general question:
What's the problem with the following construct?
class A {
bool checkit() { return true; }
...
}
class B : public A {
bool checkit() { return computedCheck(); }
...
}
class C : public A {
...
}
The only drawback I can see is the missing check for a mistake like the one
I mentioned above (revertWithConfirmation).
Stephan
