Am 10.09.2010 20:49, schrieb Pavel Sanda:
do you understand why the code in r35299
string width_str = fromqstr(WidthLE->text());
if (width_str[0] == '-')
width_str.erase(0,1);
must crash sooner or later?
No. I check if the string begins with a '-' sign and if so, I remove
this character from the string because I want to turn it into a positive
one without casting the string to a float and then back to a string.
This works well here and doesn't crash.
But as you know I'm a miserable programmer and it seems I have overseen
something.
the sad thing is that as well as the magic constants monster these lines were
not in the patch you have asked in the list. what is the point of asking for
review, when you commit different things?
These were last minute changes. The magic constant was for JMarc to
solve this but I'll revert this for now. The other issue was that i
noticed that we need positive values for width and height and thought
this is uncontroversial.
well, nobody reacted as you hoped. what do you propose now?
Give me some time please.
no problem, but the message has red bullet in my mailbox and i'm not gonna
to forget on it if you hope so :)
Having buggy code in a release is of course not acceptable. The problem
is that I have currently really pressing real life stuff and thus no
time to have a look the next 3 days I fear.
thanks for taking care and regards
Uwe
